Append Specific function to handle host in history #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinos
reviewed
Apr 2, 2022
PSFzf.Base.ps1
Outdated
| @@ -836,6 +836,39 @@ function Invoke-FzfPsReadlineHandlerHistoryArgs { | |||
| } | |||
| } | |||
|
|
|||
| function Invoke-FzfHandlerHistoryHost { | |||
| $Commands = @('icm','Invoke-Command','Enter-PSSession','etsn') | |||
There was a problem hiding this comment.
That's a bit limiting, and seems case-sensitive? Should probably be using (Get-Command $Name -Type Alias).ResolvedCommandname (plus error checking) to get the command from an alias so that it also works for custom aliases, not just icm and etsn.
There was a problem hiding this comment.
Yes ! Maybe something like that :
$Cmdlets = @('Invoke-Command','Enter-PSSession')
$Alias = (get-alias |? { $Cmdlets -contains $_.ResolvedCommand }).Name
$Commands = $Cmdlets + $Alias
And as in Powershell 5, Get-Service, Get-Process, Get-WmiObject used to have a "-ComputerName" parameters, this entries should be searched in history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fzf allow to complete ssh|telnet command with a list of known hosts. The purpose of this is to allow to grab all host (from command invoke-command or enter-pssesion ) from history and append it to prompt